chore: fix browser build plugin #6793
Merged
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like on my Windows laptop the browser build plugin is finishing before Vite finish building the UI and so there is no UI entry point in the dist folder.
With this PR we ensure the
browser/dist/client/__vitest__
folder will always have at least the UI entry point./cc @patak-dev IIRC Vite will copy the entry point after building the assets, please confirm this (I think it is true: I deal this it in the PWA plugin)
✔️ confirmed (check step 10 here ;) ) https://vite-pwa-org.netlify.app/guide/cookbook.html#vite-build-cli
Vitest hanging when running any browser test with the UI in my local, running the
test:browser:preview
script with--reporter=hanging-process
:Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.